Add unit test case and fix filename confusion

pypa · Feb 2, 2020 · baa0897 · baa0897
1 parent b9607ff
commit baa0897
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 30 deletions.
diff --git a/cibuildwheel/resources/constraints-python2.txt b/cibuildwheel/resources/constraints-python2.txt
diff --git a/cibuildwheel/util.py b/cibuildwheel/util.py
@@ -100,7 +100,7 @@ def get_for_python_version(self, version):
         # try to find a version-specific dependency file e.g. if
         # ./constraints.txt is the base, look for ./constraints-python27.txt
         base, ext = os.path.splitext(self.base_file_path)
-        specific = base + '-{}{}'.format(version_parts[0], version_parts[1])
+        specific = base + '-python{}{}'.format(version_parts[0], version_parts[1])
         specific_file_path = specific + ext
         if os.path.exists(specific_file_path):
             return specific_file_path

diff --git a/unit_test/dependency_constraints_test.py b/unit_test/dependency_constraints_test.py
@@ -0,0 +1,21 @@
+from cibuildwheel.util import DependencyConstraints
+import os
+
+def test_defaults():
+    dependency_constraints = DependencyConstraints.with_defaults()
+
+    project_root = os.path.dirname(os.path.dirname(__file__))
+    resources_dir = os.path.join(project_root, 'cibuildwheel', 'resources')
+
+    assert os.path.samefile(
+        dependency_constraints.base_file_path,
+        os.path.join(resources_dir, 'constraints.txt')
+    )
+    assert os.path.samefile(
+        dependency_constraints.get_for_python_version('3.8'),
+        os.path.join(resources_dir, 'constraints.txt')
+    )
+    assert os.path.samefile(
+        dependency_constraints.get_for_python_version('2.7'),
+        os.path.join(resources_dir, 'constraints-python27.txt')
+    )