action: use python 3.10 to run the GitHub Action #1113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayeut
commented
May 22, 2022
Comment on lines
+69
to
+81
| - name: Get some sample wheels (GitHub Action) | ||
| uses: ./ | ||
| with: | ||
| package-dir: sample_proj | ||
| output-dir: wheelhouse_action | ||
| env: | ||
| CIBW_ARCHS_MACOS: x86_64 universal2 arm64 | ||
|
|
||
| - uses: actions/upload-artifact@v3 | ||
| with: | ||
| name: sample_wheels_action | ||
| path: wheelhouse_action | ||
|
|
There was a problem hiding this comment.
There was no test for the GitHub Action so I duplicated the sample wheels steps to test the action.
|
On second thought, this might have too many side-effects (mainly, PATH is updated but never reverted by setup-python). |
thanks for the attention to detail here! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can use setup-python in the composite GitHub Action & use that python to run cibuildwheel with pipx.
This allows to drop python 3.6 without losing support for ubuntu-18.04 runners c.f. #508.