-
Notifications
You must be signed in to change notification settings - Fork 293
Rename diagram.md to diagram.html, because it is HTML
#1697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Also use plain `include` directive
joerick
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i guess this improves editor support?
|
And also clears the confusion that such diagrams are possible with pure markdown. ) |
|
Aah, i think i remember why i didn't do this. HTML is valid in markdown, but HTML blocks in markdown files can't have multiple newlines or the markdown parser starts to fiddle with it and insert |
|
I am not sure included files are additionally processed, asked here - mondeja/mkdocs-include-markdown-plugin#187 It is not clear if the include is done before markdown is parsed and converted, or after. |
|
The plugin works on the markdown before it's parsed by mkdocs. |
|
@joerick mondeja/mkdocs-include-markdown-plugin#187 (comment) the answer is that no processing is done. |
|
i'm pretty sure that he is saying that the plugin doesn't do any processing. But the plugin is working at the markdown level, mkdocs will still process it into HTML later. |
|
Asked for additional clarification. |
|
The change makes sense to me, see this explanation: mondeja/mkdocs-include-markdown-plugin#187 (reply in thread) |
|
Ah, I think I get it. I had the idea that multiple newlines broke markdown's parsing of HTML blocks, but I think this is where markdown parsers vary. In my editor, HTML blocks in markdown files have to be continuous, otherwise they don't preview/format correctly: But I just tested it and it seems that mkdoc's markdown parser doesn't have the same limitation (agreeing with @mondeja's analysis). (I suppose from a purity point of view, a pure HTML include directive would be cool, but it might also be a can of worms and including HTML-in-md seems to be working fine here.) |

Also use plain
includedirective