chore: un-pin virtualenv update #1830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
converting to draft while I debug Windows builds. |
virtualenv has been pinned to 20.21.1 in order to be able to create python 3.6 venvs. This commit allows to pin virtualenv for given versions of pythons which in turns re-allows updates as a default.
mayeut
commented
May 19, 2024
| @@ -111,7 +111,6 @@ def test_dependency_constraints_file(tmp_path, build_frontend_env): | |||
| """ | |||
| pip=={pip} | |||
| delocate=={delocate} | |||
| importlib-metadata<3,>=0.12; python_version < "3.8" | |||
There was a problem hiding this comment.
Failing tests on windows came from this pin.
I'm not sure exactly why since I can't really debug on Windows.
All I can say is that it was causing some backtracking in the pip resolver in order to install an old version of virtualenv (2.16.2).
henryiii
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
virtualenv has been pinned to 20.21.1 in order to be able to create python 3.6 venvs.
This commit allows to pin virtualenv for given versions of pythons which in turns re-allows updates as a default.