Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove nosetests from tests and docs #1898

Merged
merged 1 commit into from
Jun 30, 2024
Merged

chore: remove nosetests from tests and docs #1898

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions docs/options.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1383,9 +1383,6 @@ Platform-specific environment variables are also available:<br/>
!!! tab examples "Environment variables"

```yaml
# Run the project tests against the installed wheel using `nose`
CIBW_TEST_COMMAND: nosetests {project}/tests

# Run the package tests using `pytest`
CIBW_TEST_COMMAND: pytest {package}/tests

Expand All @@ -1402,9 +1399,6 @@ Platform-specific environment variables are also available:<br/>

```toml
[tool.cibuildwheel]
# Run the project tests against the installed wheel using `nose`
test-command = "nosetests {project}/tests"

# Run the package tests using `pytest`
test-command = "pytest {package}/tests"

Expand Down Expand Up @@ -1510,7 +1504,7 @@ Platform-specific environment variables are also available:<br/>
CIBW_TEST_REQUIRES: pytest

# Install specific versions of test dependencies
CIBW_TEST_REQUIRES: nose==1.3.7 moto==0.4.31
CIBW_TEST_REQUIRES: pytest==8.2.2 packaging==24.1
```

!!! tab examples "pyproject.toml"
Expand All @@ -1522,7 +1516,7 @@ Platform-specific environment variables are also available:<br/>

# Install specific versions of test dependencies
[tool.cibuildwheel]
test-requires = ["nose==1.3.7", "moto==0.4.31"]
test-requires = ["pytest==8.2.2", "packaging==24.1"]
```

In configuration files, you can use an array, and the items will be joined with a space.
Expand Down
4 changes: 2 additions & 2 deletions test/test_testing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,8 +135,8 @@ def test_failing_test(tmp_path):
project_dir,
output_dir=output_dir,
add_env={
"CIBW_TEST_REQUIRES": "nose",
"CIBW_TEST_COMMAND": "nosetests {project}/test",
"CIBW_TEST_REQUIRES": "pytest",
"CIBW_TEST_COMMAND": f"{utils.invoke_pytest()} {{project}}/test",
# manylinux1 has a version of bash that's been shown to have
# problems with this, so let's check that.
"CIBW_MANYLINUX_I686_IMAGE": "manylinux1",
Expand Down
Loading