-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build CPython 3.13 by default #1950
Conversation
Enable building with CPython 3.13 by default, no longer requiring prerelease_pythons flag to be set true.
for more information, see https://pre-commit.ci
I see some CI failing. I think one error is the The other errors I don't understand directly, so some help with them is appreciated! Maintainers, feel free to directly modify this PR (push to this branch) by the way. |
Even with 3.13 being enabled by default, cp313t is still behind a flag for now. This commit updates the test accordingly.
Ah I missed that one, thanks! So far it all looks green. |
There we go, all green! |
Thanks for merging! In what timeframe do you think a new release would be possible? |
If it depends on me, tonight. |
I found that on macOS and Windows it is still necessary to add |
No, it shouldn’t be |
Boost-histogram is building 3.13 windows wheels (and macOS both flavors) without the flag, just checked. Is this 3.13 in general or maybe 3.13t? We will be releasing a new patch release of pybind11 with PyMutex, then I’ll be trying that (3.13t) in boost-histogram. |
Pyinstrument is building 3.13 without the flag, too. |
Okay, never mind then, it's probably something else (even if adding the env var fixed it for me). And it was regular |
You'll need v2.20.0 , you're on 2.19.0 :) (Or, at least you were in the failing run) |
(2.20 is also the one with the ABI stable Python 3.13rc1) |
Argh, made the updates to 2.20 but missed one indeed, for Windows. And the macOS ones were free-threaded. Sorry for the noise. |
Now that everyone had about 3 months to get their Python 3.13 wheels building, and 3.13 was released as stable, would this be a good time to talk about building Python 3.13 free-threaded ( |
Just my two cents but I don't think free-threading wheels should be built by default as long as the feature is considered experimental by CPython developers. |
One thing that might have improved the experience would be if we could detect and enable automatically if the free-threaded classifiers were present. However, the free-threaded classifiers discussion devolved into bike-shedding and died. pypa/trove-classifiers#177 & https://discuss.python.org/t/free-threading-trove-classifier/62406 |
Enable building with CPython 3.13 by default, no longer requiring
prerelease_pythons
flag to be set true.Merge after #1949 is merged.
Builds upon last-year PRs: #1226 and #1565.