Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about the planned change of the manylinux default #1992

Merged
merged 8 commits into from
Oct 2, 2024

Conversation

joerick
Copy link
Contributor

@joerick joerick commented Sep 1, 2024

As per discussion in #1772, note about the planned update of the manylinux default.

docs/options.md Outdated Show resolved Hide resolved
Co-authored-by: Henry Schreiner <HenrySchreinerIII@gmail.com>
@joerick joerick marked this pull request as ready for review September 6, 2024 11:20
@Czaki
Copy link
Contributor

Czaki commented Sep 6, 2024

Maybe it will be a good practice to promise that all changing manylinux images should be end of January?

@joerick
Copy link
Contributor Author

joerick commented Sep 9, 2024

Maybe it will be a good practice to promise that all changing manylinux images should be end of January?

I'm afraid I don't follow your logic. What's the relevance of January? The proposal was to change the default at the end of June 2025.

@Czaki
Copy link
Contributor

Czaki commented Sep 9, 2024

I'm afraid I don't follow your logic. What's the relevance of January? The proposal was to change the default at the end of June 2025.

I do not know why I read June as January.
In general, when I read in black documentation, that they promise not to introduce changes in style guide except begin of the year. And maybe having information that a change of some default value will happen only at given month may simplify life.

@joerick
Copy link
Contributor Author

joerick commented Sep 11, 2024

Oh, I see. Yeah, that's a good idea. We're often beholden to external factors too, but let's see if it works to stick to a June cadence on the next one.

@joerick
Copy link
Contributor Author

joerick commented Sep 11, 2024

@henryiii @mayeut , approval/review here would be good. Test fail is Travis and unrelated.

Copy link
Contributor

@henryiii henryiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me, but mostly needs @mayeut's approval.

Copy link
Member

@mayeut mayeut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see. Yeah, that's a good idea. We're often beholden to external factors too, but let's see if it works to stick to a June cadence on the next one.

Indeed external factors do exist and not only for cibuildwheel.
In order for the image sizes of manylinux not to grow too much, I'll try to remove EOL ones (when they can be removed) at the time of the new Python 3.x beta.
Given the release schedule of last CPython versions, this generally happens at the beginning of May.

docs/options.md Outdated Show resolved Hide resolved
Co-authored-by: Matthieu Darbois <mayeut@users.noreply.github.com>
@joerick joerick requested a review from mayeut September 29, 2024 15:53
docs/options.md Outdated Show resolved Hide resolved
docs/options.md Outdated Show resolved Hide resolved
@mayeut mayeut merged commit ec591cd into main Oct 2, 2024
12 of 13 checks passed
@mayeut mayeut deleted the default-manylinux-change-docs branch October 2, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants