chore: cleanup for 3.11 #2276
Open
chore: cleanup for 3.11 #2276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
force-pushed
the
henryiii/chore/cleanup311
branch
from
2c489f7 to
64e75d8
Compare
mayeut
reviewed
Feb 15, 2025
Comment on lines
-268
to
+273
| def format_table(self, table: SettingTable) -> str: | ||
| @staticmethod | ||
| def format_table(table: SettingTable) -> str: | ||
| return " ".join(f'{k}="{v}"' for k, v in table.items()) | ||
|
|
||
| def merge_values(self, before: str, after: str) -> str: | ||
| @staticmethod | ||
| def merge_values(before: str, after: str) -> str: |
There was a problem hiding this comment.
These 2 changes shall probably be reverted, they do not respect the prototype inherited from OptionFormat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cleanup, focused on some things 3.11 provides.