chore: enable more Ruff checks #2654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
requested review from
agriyakhetarpal,
freakboy3742,
hoodmane and
ryanking13
as code owners
joerick
approved these changes
Nov 7, 2025
Contributor
joerick
left a comment
joerick
left a comment
There was a problem hiding this comment.
Yeah, looks good to me! I'm a little dubious about TC006 but I can run with it if you prefer it.
agriyakhetarpal
approved these changes
Nov 7, 2025
Member
agriyakhetarpal
left a comment
agriyakhetarpal
left a comment
There was a problem hiding this comment.
Looks good to me, thanks!
Contributor
Author
|
I thought TC006 looks a little strange at first, but I’ve gotten used to it; casting should have no effect at run time, and using a cast shouldn’t force an import or declaration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding more checks. Used sp-ruff-checks from sp-repo-review. Mostly improved typing.
After:
