Revert "Keeping virtualenv<20 on macOS, until problems get fixed by new release" #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YannickJadoul
force-pushed
the
undo-virtualenv-workaround
branch
from
a584c5f
to
8c890c2
Compare
YannickJadoul
force-pushed
the
undo-virtualenv-workaround
branch
4 times, most recently
from
a12e25a
to
266b100
Compare
|
what with this? |
…ew release" This reverts commit 691174c.
YannickJadoul
force-pushed
the
undo-virtualenv-workaround
branch
from
266b100
to
7d0cc37
Compare
|
Still waiting for a fix of one issue. The issue reported in pypa/virtualenv#1561 was fixed, and the problem in The problem in |
|
virtualenv 20.0.7 is released. Maybe build restart? |
The release is unrelated. I had already tried out 20.0.6, tried out 20.0.7 just now, and it's no difference. The issue is unrelated to virtualenv, btw:
|
|
@joerick Got this working. Good to merge? |
joerick
reviewed
Feb 28, 2020
Serves me right for editing code in the github editor!!
joerick
approved these changes
Feb 28, 2020
|
Thanks, @joerick! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue (pypa/virtualenv#1561) was fixed by PR pypa/virtualenv#1641, and is now released in virtualenv 20.0.5. Let's undo the hack/workaround.