-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python3.9 support #382
Conversation
Add Python 3.9 (beta 3) to builds
Update dependencies to get python 3.9 support on s390x
base on this draft PR/branch pypa/cibuildwheel#382
base on this draft PR/branch pypa/cibuildwheel#382
@joerick thanks a lot, I'm taking this one for a test drive, when is the plan to merge this ?, only in October when python3.9 would be released formally ? |
The credit's @YannickJadoul's! We'll be merging this once Python3.9 is ABI stable, which is the first release candidate I believe. |
base on this draft PR/branch pypa/cibuildwheel#382 currently skipping windows for python3.9, since the tests are not working
base on this draft PR/branch pypa/cibuildwheel#382 currently skipping windows for python3.9, since the tests are not working
base on this draft PR/branch pypa/cibuildwheel#382 currently skipping windows for python3.9, since the tests are not working
Might be worth rebasing onto 1.5.5, though? |
Good point, I'll get on that |
Also, Python 3.9.0b5 is out, we should update to that once manylinux gets it pypa/manylinux#682 |
Hurraaaaay, 3.9 rc1! Almost there, except for pypa/manylinux#710! If this also works, what's the plan, then, @joerick? Do you want to push a release soon and then later have another patch release when 3.9 officially gets release? |
4d0cf83
to
a345008
Compare
Only manylinux2014 on ppc64le is missing. Apparently Travis's ppc64le build is acting up. |
from the announcement post on python-dev https://mail.python.org/archives/list/python-dev@python.org/thread/FFVG5DAE7RHE5ZYUVVJW5TPAZ2ALRFHB/
Based on the above, I think we should be merging this PR and releasing a version of cibuildwheel that builds packages against 3.9.0rc1. It does make me wonder what happens if a bug is found, but I guess that's what the release candidate phase is for :) Does anyone know if PyPI is accepting 3.9 wheels yet? EDIT: it appears PyPI is accepting them - see https://pypi.org/project/scylla-driver/#files for an example |
Ah, great, I tried looking, but couldn't immediately find one :-) Anyhow, sure, as you think is best. ABI should be stable now, I suppose, so ... all that's missing is that |
Okie doke, I'll merge this soon and make a release. Do we need to worry about the missing |
With a bit of luck, we'll soon enough have a PyPy release that fixes all our problems there, but I guess we shouldn't wait for that. Worrying about |
Scratch that. I am actually trying: https://travis-ci.org/github/YannickJadoul/manylinux/builds/724689320 |
OK, nevermind. Not such great news, from the ppc64le side: see pypa/manylinux#758. You can probably release, and we can add a patch when this gets fixed? |
Fantastic, thank you @YannickJadoul for updating those. Including a note in the readme about ppc64le is a good idea. I'll also note it in the release notes. |
Now that they merged PR for python3.9 support and that branch is deleted, we should move back to formal version Ref: pypa/cibuildwheel#382
Now that they merged PR for python3.9 support and that branch is deleted, we should move back to formal version Ref: pypa/cibuildwheel#382
Python 3.9 is in beta, and not yet ABI stable, so you shouldn't publish wheels with it yet.
But if you want to check that your wheels build on Python 3.9, try this
python3.9
branch!To try this branch, in your CI config, replace
with