Macos patch fix #506
Merged
Macos patch fix #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cross referencing #502. |
YannickJadoul
approved these changes
Jan 1, 2021
|
I found test only on 10.15 |
|
Once merged I'm happy to do a hotfix 1.7.4 if that's useful @Czaki? |
|
Are there CI systems running 10.14? I'm pretty sure there must be (GHA/Azure do not have an official 10.14 advertised runner anymore, but assuming some of the other ones are not?) If so, I think it's a great idea to backport the fix and release a 1.7.4 while we work on archs & Universal2. If not, still wouldn't be a bad idea. |
|
I run 10.14 on Azure Pipelines. |
henryiii
approved these changes
Jan 2, 2021
|
10.14 doesn't seem to be advertised on GHA/Azure anymore, so I don't think we need to test with it. |
|
Released as v1.7.4 (note that release doesn't include the CIBW_ARCHS work) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On MacOS 10.14 current patch syntax does not work (I build code with OpenMP, which needs libomp from
brew).