feat: Windows filtering and sets #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryiii
force-pushed
the
feat/windowsfilter
branch
from
57c963d
to
9128d8c
Compare
This was referenced Jan 1, 2021
henryiii
force-pushed
the
feat/windowsfilter
branch
2 times, most recently
from
ad76134
to
550612d
Compare
Co-authored-by: Matthieu Darbois <mayeut@users.noreply.github.com>
henryiii
force-pushed
the
feat/windowsfilter
branch
from
550612d
to
a99e0de
Compare
|
Any opinions? This unifies and simplifies the handling of architectures a bit, but shouldn't be controversial? Unless we want docs changes? |
joerick
reviewed
Jan 4, 2021
YannickJadoul
approved these changes
Jan 4, 2021
henryiii
force-pushed
the
feat/windowsfilter
branch
from
a99e0de
to
c97d3bc
Compare
joerick
added a commit
that referenced
this pull request
Jan 5, 2021
This will change when #507 is merged
henryiii
force-pushed
the
feat/windowsfilter
branch
from
c97d3bc
to
fce7c70
Compare
|
Pulled arch checking into one place, and now they all behave the same way - specifying an empty set or an arch that's not allowed is an error. |
That's great. Already approved, but ... yep, good to merge, if you ask me! |
|
I didn't order the includes correctly in one place, but didn't want to rebuild after pushing so added #518 instead. I can fix it though. |
joerick
approved these changes
Jan 5, 2021
|
|
||
| import certifi | ||
|
|
||
| from .environment import ParsedEnvironment | ||
| from .typing import PathOrStr | ||
|
|
||
| if sys.version_info < (3, 8): | ||
| from typing_extensions import Literal |
There was a problem hiding this comment.
Everything that goes into typing that can be backported goes here. :)
henryiii
added
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #482, use sets instead of lists for Archs, and make Windows handling behave more like Linux, where one arch will only use that arch. (Eventually, maybe could include ARM for windows, perhaps?).
No docs changes (yet).
I converted to sets, then added the changes from @mayeut.