Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: empty CIBW_BUILD should still count as "*" #588

Merged
merged 1 commit into from
Feb 12, 2021

Conversation

henryiii
Copy link
Contributor

Mentioned in #587 - currently, there's an asymmetry between not setting CIBW_BUILD, and setting it to "", that can be surprising, especially in a matrix. This treats an empty string the same way as being undefined.

@henryiii
Copy link
Contributor Author

Ouch, tests are pulling from latest? Manylinux2010 tests will need to stop trying to do that for Py2 for latest.

@henryiii henryiii changed the title fix: empty CIBW_BUILD still counts as "*" fix: empty CIBW_BUILD should still count as "*" Feb 11, 2021
cibuildwheel/__main__.py Outdated Show resolved Hide resolved
@henryiii
Copy link
Contributor Author

Tests are dead until #591 goes in.

@YannickJadoul
Copy link
Member

Tests are dead until #591 goes in.

Sorry, yeah. I'd just noticed :-)

@henryiii henryiii merged commit 2da8e12 into pypa:master Feb 12, 2021
@henryiii henryiii deleted the fix/empty_BUILD branch February 12, 2021 15:31
@henryiii
Copy link
Contributor Author

PS: I also am somewhere between disliking and vehemently hating the a, b = c, d syntax. You'll notice the long block of code in mplhep I was refactoring had tons of it. I don't find it any better than writing a = c; b = d;, which is a fake way to compress lines, losing readability. And if you are trying to scan the code base for b =, it hides this by being the only construct in Python (except for the walrus operator, in 3.8+) that does have the assignment as the first item in a line. For a, b = c or a, b = b, a, you are doing something explicit (tuple unpacking or variable swapping), so losing first item assignment is a valid price to pay. But not for assignment grouping - a blank line does that much better.

(I'm planning to add do/do not's to Level Up Your Python, and this is one I'm planning to add. Mentioning it here gives the option for rebuttals before I add it. :) )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants