Add wheel with a C extension to test mounting #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This recreates the source to the `tests/minimext*.whl` wheels with a couple of differences: * The C extension is placed in the minimext package rather than being a top level package. * A Python implementation of the C extension is provided to make it easier for pure Python programmers to understand / modify. This also adds a script `build_wheels.sh` that will install Python interpreters and build the minimext wheel for different Python versions with and without adding the `EXTENSIONS` metadata file. Related to pypa#222
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #229 +/- ##
=======================================
Coverage 81.49% 81.50%
=======================================
Files 24 24
Lines 8885 8888 +3
Branches 1747 1746 -1
=======================================
+ Hits 7241 7244 +3
- Misses 1300 1301 +1
+ Partials 344 343 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Similar to other commits, failures are due to the following job failing on macOS: distlib/.github/workflows/package-tests.yml Lines 55 to 59 in 5235013 |
stewartmiles
force-pushed
the
source_for_test_wheel
branch
from
2f0b158 to
4a67db8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This recreates the source to the
tests/minimext*.whlwheels with a couple of differences:This also adds a script
build_wheels.shthat will install Python interpreters and build the minimext wheel for different Python versions with and without adding theEXTENSIONSmetadata file.Fixes #227
Related to #222