DOC: Extend Windows rpath error message with likely cause #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend the error message for attempting to call `runtime_library_dir_option` on Windows with the most likely way I have found to trigger the call, creating an `Extension` that specifies `runtime_library_dirs`. Hopefully this will give users something to search for in their `setup.py` and a starting point for what to change. Inspired by pypa/setuptools#3450.
jaraco
reviewed
Jul 31, 2022
distutils/cygwinccompiler.py
Outdated
| @@ -341,7 +341,9 @@ def __init__(self, verbose=0, dry_run=0, force=0): | |||
|
|
|||
| def runtime_library_dir_option(self, dir): | |||
| raise DistutilsPlatformError( | |||
| "don't know how to set runtime library search path on Windows" | |||
| "don't know how to set runtime library search path on Windows\n" | |||
There was a problem hiding this comment.
The original message appears to be a copy/paste from line 279. Probably we'll want to consolidate the messaging (even though one is an error and one is a warning). I'll use this commit as inspiration for a more concise message.
This was referenced Aug 1, 2022
This was referenced Aug 8, 2022
daregit
pushed a commit
to daregit/yocto-combined
that referenced
this pull request
May 22, 2024
Merge with pypa/distutils@129480b, including substantial delinting and cleanup, some refactoring around compiler logic, better messaging in cygwincompiler (pypa/distutils#161). (From OE-Core rev: bc488be5a8d260a0bdc69c37173a7168706f9be3) Signed-off-by: Wang Mingyu <wangmy@fujitsu.com> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
daregit
pushed a commit
to daregit/yocto-combined
that referenced
this pull request
May 22, 2024
Merge with pypa/distutils@129480b, including substantial delinting and cleanup, some refactoring around compiler logic, better messaging in cygwincompiler (pypa/distutils#161). (From OE-Core rev: bc488be5a8d260a0bdc69c37173a7168706f9be3) Signed-off-by: Wang Mingyu <wangmy@fujitsu.com> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the error message for attempting to call
runtime_library_dir_optionon Windows with the most likely way I have found to trigger the call, creating anExtensionthat specifiesruntime_library_dirs.Hopefully this will give users something to search for in their
setup.pyand a starting point for what to change. Inspired by pypa/setuptools#3450.Since this is now an error, should this be documented in the setuptools documentation for
Extensionas well?