Honor sysconfig.get_preferred_scheme when selecting install schemes. #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaraco
force-pushed
the
feature/preferred-schemes
branch
from
1f928a1
to
f32af4e
Compare
jaraco
changed the title
|
@Bo98 Would you take a look at this patch and possibly test it in your environment? I did find that tests failed on my macOS install before I added the |
jaraco
commented
Dec 17, 2021
| @@ -515,9 +520,17 @@ def finalize_other(self): | |||
| "I don't know how to install stuff on '%s'" % os.name) | |||
|
|
|||
| def select_scheme(self, name): | |||
| os_name, sep, key = name.partition('_') | |||
There was a problem hiding this comment.
I acknowledge this approach is a little janky. I'd prefer to change the signature to accept the key instead, but I want to maintain the existing interface in case some of the transitional implementations are overriding it.
|
I'd like to proceed with this change. I'll roll it out and we can iterate subsequently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76.