Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provides_extra .none ...? #228

Closed
wimglenn opened this issue Nov 2, 2018 · 2 comments
Closed

provides_extra .none ...? #228

wimglenn opened this issue Nov 2, 2018 · 2 comments
Labels

Comments

@wimglenn
Copy link
Contributor

wimglenn commented Nov 2, 2018

The metadata generated by flit build advertises my distribution as providing an extra called .none:

provides_extras: ['.none', 'doc', 'test']

Was that intended to be publicly available, or is it a bug? Reading the source, it looks as though this was just supposed to be an an internal token, not actually making it into the final package. I would rather flit not create the .none extra in project metadata.

@takluyver takluyver added the bug label Nov 3, 2018
@takluyver
Copy link
Member

You're right, that's meant to be an internal token, it shouldn't be visible in the resulting packages.

@wimglenn
Copy link
Contributor Author

wimglenn commented Nov 3, 2018

Here is a minimal setup to recreate the issue. flit==1.2.1

In pyproject.toml:

[build-system]
requires = ["flit"]
build-backend = "flit.buildapi"

[tool.flit.metadata]
module = "example"
author = "wim"
author-email = "wim@example.org"
home-page = "https://www.example.org"
requires = ["wimpy"]

In example.py:

"""my proj"""
__version__ = "0.1"

If commenting out the line requires = ["wimpy"] in markup, then the .none extra is not created.

charliermarsh added a commit to astral-sh/uv that referenced this issue Feb 16, 2024
## Summary

Some packages erroneously include an extra named `.none`. It turns out
that certain versions of `flit` included this by accident:
pypa/flit#228.

This PR adds leniency for that specific extra name.

Closes #1363.

Closes #1399.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants