-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEP 660 support #400
PEP 660 support #400
Conversation
- split abstract and motivation - add terminology and goals - recommend +editable local version identifier - add .pth as an option in what to put in the wheel - add frontend requirements
56a03ac
to
c6d3ed9
Compare
Updated to match the latest PEP 660 version. |
Thanks @sbidoul - this looks reasonable enough to me, if you'd like to add a test or two. |
Thanks for the review. I should come back to this later this month. |
c6d3ed9
to
2a87858
Compare
@takluyver this should now be ready. I'm not sure how to test |
Thanks, I'll take a look. :-) I'm not sure what you mean about tests for buildapi relying on the |
Nice and simple, thank-you. I think if you can add a simple test to exercise the function exposed in buildapi, this should be fine. |
@takluyver I somehow missed the buildapi tests in flit_core. Proof I needed holidays, I guess. I now added the missing tests. |
@takluyver FYI PEP 660 has been merged in pip and will be part of the 21.3 release in October. \o/ |
Thanks, and congratulations on getting the PEP you worked on accepted & implemented! |
Thanks, it was quite a ride, I should say :) |
This is a very rough proof of concept for
build_wheel_for_editable
, as described in https://discuss.python.org/t/standardising-editable-mode-installs-runtime-layout-not-hooks/4098/55 and prototyped in pypa/pip#8212.It works by adding a
.pth
file in the transient wheel, and should therefore behave identically asflit install --pth-file
.