Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix development installs #472

Merged
merged 2 commits into from
Nov 23, 2021
Merged

Fix development installs #472

merged 2 commits into from
Nov 23, 2021

Conversation

takluyver
Copy link
Member

A symlink install with a src layout would go wrong because it tried to create a src directory in site-packages, and a .pth file would separately go wrong because it didn't make the path absolute before writing it. Both problems were introduced by #468.

Closes #471

@takluyver
Copy link
Member Author

I'll likely merge this and do a release tomorrow, if no-one spots a problem with it.

@takluyver takluyver added this to the 3.5.1 milestone Nov 23, 2021
@takluyver takluyver merged commit ec27d20 into master Nov 23, 2021
@takluyver takluyver deleted the fix-dev-install-src branch November 23, 2021 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editable installs with src in 3.5.0
1 participant