-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bootstrap script/wheel module for flit_core #511
Conversation
Ah, I think I missed something, shouldn't this be installed? If so, this should live under the I will look at this in more detail later. |
Only the wheel builder is installed since the |
b66c0db
to
e3a9500
Compare
Thanks for this. In the interests of keeping the extra script as simple as possible, and minimising coupling between the script and the internals of flit_core, I'd like to have the script only do installation, and use I know what I want this to look like, so I hope you won't mind if I just make the changes directly rather than asking you to do them. |
OK, I hope this works for you. I've got rid of the globbing inside the script - if you know there's only one suitable wheel in a directory, you can always use |
Yeah, I don't think that should be an issue, I had just attempted to preserve the combo build+install option from #481 but for our use case where we do build+install stage separation a combo build+install is not actually needed.
Yeah, I think this should work for us. |
Great, thanks. I've updated the bootstrapping doc. I'll give it another day or two in case other maintainers want to look at it, but otherwise I think this can go in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Improved version of #481 based on comments here.
Details from help: