Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn if packages still using flit.buildapi instead of flit_core.buildapi #674

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

takluyver
Copy link
Member

I'm not 100% sold on this: the removal would break things that might otherwise work, and it's a tiny bit of complexity by itself. But any project still specifying flit.buildapi is probably also using old-style metadata ([tool.flit.metadata] table), which 4.0 will likely not support (#673), and that is enough complexity to be worth cleaning up.

  • flit.buildapi added in 0.12 (November 2017)
  • flit_core.builadpi added in 2.0 (November 2019)
  • New-style metadata ([project] from PEP 621) added in 3.2 (March 2021)

Using python -m build, this warning is visible. Using pip wheel (and presumably any other pip command that does a build), it isn't (pip wheel -v shows it). I don't think there's anything we can do to make it more visible, but a warning that only some people see is better than no warning.

First step for #519

@takluyver takluyver added this to the 3.10 milestone Jan 28, 2024
@takluyver takluyver merged commit 9b1ef13 into main Oct 18, 2024
14 of 16 checks passed
@takluyver takluyver deleted the warn-flit-buildapi branch October 18, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant