Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: fix compatibility with Python 3.14 #684

Merged
merged 1 commit into from
May 29, 2024
Merged

Conversation

tacaswell
Copy link
Contributor

The ast.Str class was deprecated in 3.8 and will be removed in 3.14

@takluyver
Copy link
Member

Thanks, nice catch! flit_core still supports Python down to 3.6, so could I ask you to do a little bit of compatibility code here? Something simple like if sys.version_info >= (3, 8) should be fine.

I know I'm pretty weirdly conservative on this. In most projects I'd have dropped such old Python versions some time ago. But flit_core is kind of in a special position, being used to build a whole lot of other packages, including key packaging tools like build & installer. Python 3.6 is still accounting for 2-3% of downloads from PyPI, so I'd rather keep it compatible than have some users getting an older version of flit_core.

The ast.Str class was deprecated in 3.8 and will be removed in 3.14
@takluyver takluyver added this to the 3.10 milestone May 29, 2024
@takluyver takluyver merged commit e38b172 into pypa:main May 29, 2024
14 checks passed
@takluyver
Copy link
Member

Thanks Tom!

@tacaswell tacaswell deleted the fix/py314 branch May 29, 2024 15:26
@AA-Turner
Copy link

AA-Turner commented Jul 23, 2024

Sorry to be one of those people, but please would it be possible to have a release with this commit? I'm currently unable to test with Python 3.14 in CI as pip is failing with this error.

A

@pmp-p
Copy link

pmp-p commented Oct 8, 2024

Sorry to be one of those people too, but please would it be possible to have a release with this commit? I'm currently unable to test with Python 3.14 in CI as pip is failing with this error.

please.

@takluyver
Copy link
Member

Flit 3.10 is out now, which hopefully solves this. Although to be honest, I think testing on Python "3.14" at present is a waste of energy - I would look to start testing around when it's a beta. But that's up to you.

@AA-Turner
Copy link

Thanks @takluyver! We run Sphinx on the tip of CPython for doctests so testing the latest release is useful, but I agree perhaps less so in the general case.

A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants