Skip to content

Commit

Permalink
Merge pull request #140 from hugovk/oidc-whitespace
Browse files Browse the repository at this point in the history
This change removes accidental double whitespaces from the OIDC CI log that were caused by a misconception that the arguments of `echo` would be joined the same way as Python's implicit string concatenation works.
  • Loading branch information
webknjaz authored Apr 1, 2023
2 parents 48b317d + 65bf8a8 commit 9c859e9
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions twine-upload.sh
Original file line number Diff line number Diff line change
Expand Up @@ -44,17 +44,17 @@ if [[ "${INPUT_USER}" == "__token__" && -z "${INPUT_PASSWORD}" ]] ; then
# No password supplied by the user implies that we're in the OIDC flow;
# retrieve the OIDC credential and exchange it for a PyPI API token.
echo \
'::notice::Attempting to perform OIDC credential exchange ' \
'to retrieve a temporary short-lived API token for authentication ' \
'::notice::Attempting to perform OIDC credential exchange' \
'to retrieve a temporary short-lived API token for authentication' \
"against ${INPUT_REPOSITORY_URL}"
INPUT_PASSWORD="$(python /app/oidc-exchange.py)"
elif [[ "${INPUT_USER}" == '__token__' ]]; then
echo \
'::notice::Using a user-provided API token for authentication ' \
'::notice::Using a user-provided API token for authentication' \
"against ${INPUT_REPOSITORY_URL}"
else
echo \
'::notice::Using a username + password pair for authentication ' \
'::notice::Using a username + password pair for authentication' \
"against ${INPUT_REPOSITORY_URL}}"
fi

Expand Down

0 comments on commit 9c859e9

Please sign in to comment.