skipped pushed release

[Borda]

We used the template from the main page with setting conditional push on adding a new tag but it seems to be skipped. We have v0.7.2rc4, the workflow was correctly triggered and running up to the Build step, but then the push was skipped... Wha are we missing?
see the action run here - https://github.com/PyTorchLightning/pytorch-lightning/runs/568469134?check_suite_focus=true

[webknjaz]

Did you push a tag? (not just commit ref)

[webknjaz]

Oh, this is the workflow that was triggered on the release event, not push. That's why it's not connected to tags. If you'd git push v0.7.2rc4, it'd work.

[webknjaz]

Doc on github.event context: https://help.github.com/en/actions/reference/context-and-expression-syntax-for-github-actions#github-context.

Doc on triggers: https://help.github.com/en/actions/reference/events-that-trigger-workflows#release-event-release.

Doc on release event structure: https://developer.github.com/v3/activity/events/types/#releaseevent.

[webknjaz]

I'm guessing you'll need to add || github.event_name == 'release' in the end of both conditions if you want those steps to be triggered both on pushes to master and on adding releases.

[Borda]

Thx for the fast reply, Ill try Lightning-AI/pytorch-lightning#1407