-
-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nudge message with magic link to create new Trusted Publisher #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woodruffw
reviewed
Aug 6, 2024
woodruffw
reviewed
Aug 6, 2024
facutuesca
force-pushed
the
pypi-tp-magic-link
branch
7 times, most recently
from
August 7, 2024 16:57
dd37137
to
baea148
Compare
webknjaz
reviewed
Sep 1, 2024
webknjaz
reviewed
Sep 1, 2024
webknjaz
reviewed
Sep 1, 2024
webknjaz
reviewed
Sep 1, 2024
facutuesca
force-pushed
the
pypi-tp-magic-link
branch
2 times, most recently
from
September 3, 2024 14:32
910d9d8
to
61b9b74
Compare
facutuesca
force-pushed
the
pypi-tp-magic-link
branch
from
September 3, 2024 14:36
61b9b74
to
5e98273
Compare
webknjaz
reviewed
Sep 4, 2024
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
@facutuesca are you planning to polish the commits or do you want me to squash? |
Go ahead and squash |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a nudge message for the user with a link to create a Trusted Publisher for the project being uploaded. The link is a "magic link", containing URL parameters that will pre-fill most of the Trusted Publisher form fields.
This was originally discussed in pypi/warehouse#13661, and currently under review in pypi/warehouse#16399.
The nudge message will only be displayed when not using Trusted Publishing, and if the index is either PyPI or TestPyPI. It looks like this:
The message is also added to the job's summary, where it's rendered as Markdown and the links are clickable.
A small Python utility script was added in order to parse the package name(s) from the distribution files.
This is ready for review, but it's a draft PR since it shouldn't be merged until PyPI's side is merged: pypi/warehouse#16399
cc @woodruffw @webknjaz