requirements: bump twine to >= 6.1 #326
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webknjaz
reviewed
Jan 22, 2025
requirements/runtime.txt
Outdated
| @@ -48,10 +48,6 @@ jaraco-context==5.3.0 | |||
| # via keyring | |||
| jaraco-functools==4.0.1 | |||
| # via keyring | |||
| jeepney==0.8.0 | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
huh, weird. I just ran the pip-compile command from the header 🤔
There was a problem hiding this comment.
ah, sys_platform == "linux", of course 🤦🏻
webknjaz
reviewed
Jan 22, 2025
requirements/runtime.txt
Outdated
| @@ -123,8 +115,6 @@ rich==13.7.1 | |||
| # via | |||
| # sigstore | |||
| # twine | |||
| secretstorage==3.3.3 | |||
There was a problem hiding this comment.
|
You may want to upgrade packaging to 24.2 while at it, to get support for metadata 2.4. See the twine 6.1 release notes. EDIT: From the linked issue, I see that the purpose of this is to get support for metadata 2.4, therefore you absolutely want to update packaging too! |
|
I'll close it in favour of maintainer-led #327 @dnicolodi you might want to submit your comment there! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #325