Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acknowledge the ARCHFLAGS environment variable on macOS #672

Merged
merged 1 commit into from
Dec 17, 2022
Merged

Acknowledge the ARCHFLAGS environment variable on macOS #672

merged 1 commit into from
Dec 17, 2022

Conversation

ofek
Copy link
Collaborator

@ofek ofek commented Dec 17, 2022

@github-actions
Copy link
Contributor

Code Coverage

Package Statements
hatch 97.26% (3950 / 4061)
hatchling 97.47% (3320 / 3406)
tests 99.99% (13236 / 13237)
Summary 99.04% (20506 / 20704)

@ofek ofek merged commit 6322dab into master Dec 17, 2022
@ofek ofek deleted the a branch December 17, 2022 14:24
@tlambert03
Copy link

this is still unreleased correct? Should we be expecting ofek/hatch-mypyc#24 to be fixed on CI yet? or not until a new hatchling is released?

@ofek
Copy link
Collaborator Author

ofek commented Dec 29, 2022

I will make a release today, sorry about that

@tlambert03
Copy link

no worries! it's the holiday season after all :)

...and maybe no hurry either? fwiw, I tried specifying requires = ["hatch@git+https://github.com/pypa/hatch.git"] in my pyproject build-system ... and I'm still seeing the same macos arch problem with cibuildwheel and mypyc that @ichard26 described seeing with black in ofek/hatch-mypyc#24

https://github.com/pyapp-kit/psygnal/actions/runs/3802582773/jobs/6468208636

(I know this PR isn't the place to discuss it :) will monitor the other issues for a resolution)

@ofek
Copy link
Collaborator Author

ofek commented Dec 29, 2022

try hatchling @ git+https://github.com/pypa/hatch.git#subdirectory=backend

@tlambert03
Copy link

tlambert03 commented Dec 29, 2022

fraid not ... wheel still builds fine, then fails during pip install in the testing phase with

...-cp37-cp37m-macosx_11_0_x86_64.whl is not a supported wheel on this platform.

https://github.com/pyapp-kit/psygnal/actions/runs/3803025510/jobs/6469068225

(this is on a macos github runner with CIBW_ARCHS_MACOS: x86_64 and ARCHFLAGS: -arch x86_64)

@ofek
Copy link
Collaborator Author

ofek commented Dec 29, 2022

you need -arch arm64 or -arch arm64 -arch x86_64

@tlambert03
Copy link

but, I'm specifically not trying to build the arm64 wheel. I'm trying to build the standard x86_64 wheel, no cross-compiling. that's what's so confusing about this whole thing 😂

@ofek
Copy link
Collaborator Author

ofek commented Dec 29, 2022

Oh, in that case I am extremely perplexed... cc @ichard26 @henryiii

@tlambert03
Copy link

if I'm not mistaken... this is the same thing that @ichard26 is running into with black (psf/black#3312). like @ichard26 noted elsewhere, it works fine if I build locally on my mac with cibuildwheel... (is that correct @ichard26?)

@ofek
Copy link
Collaborator Author

ofek commented Dec 30, 2022

@tlambert03 just so you know @ichard26 debugged this and the issue is packaging version 22.0. the only real fix is to wait for pip to upgrade their vendored version. until then, the latest release of that plugin prevents that version from being used ofek/hatch-mypyc#27

@tlambert03
Copy link

Ok, thanks for letting me know! And thanks @ichard26 for debugging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants