Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI to install to Python running installer #94
CLI to install to Python running installer #94
Changes from 22 commits
a871069
ec29913
514d71f
c600a6e
0037f48
140fd61
d78df15
b04487e
d9dd7d2
15c992b
fdfd28e
62b632d
ac2d729
c8a4390
86ff36e
679106c
73f4fae
464644b
d150edd
973ac95
8263f76
e29818e
275e73d
cf6ba41
5264e37
00810eb
546fd2d
05855a9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't actually copy what distutils does because (a)
include
is always on thesys.base_prefix
, meaning that installer will attempt to install headers under the base prefix in a virtual env, and (b) when the root is "platlib", the installation will be performed under "purelib".There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see what you mean about a) - distutils replaces
installed_base
(=sys.base_prefix
) withbase
(=sys.prefix
). We can do the equivalent easily enough, I think.I'm not sure what you mean about b) though. I don't think that root-is-purelib setting should make any difference to where the headers are installed, and I haven't spotted anything in distutils referring to another destination for them (though I could easily have overlooked it, the logic is fairly spread out).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume that if the root is platlib then the headers should be installed in platinclude, i.e. under
sys.(base_)exec_prefix
. I might be wrong that distutils does this though.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
distutils doesn't do this, never mind.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see distutils implementing that, and it doesn't seem right to me. The wheel contents are 5 separate components to be installed - purelib and platlib are separate, but there's just one
headers
directory, noplatheaders
. As a convenience, the root of the wheel is considered either platlib or purelib, but I don't think that should affect where any of the other components go.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, great. I'll deal with prefix vs base_prefix at some point later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The latest change - 275e73d - should use prefix in place of base_prefix so headers can be installed in a virtualenv.