Add pypy3.7 7.3.5

[mayeut]

Fix #1099

[mayeut]

@mattip, could you review this PR please ?

[mattip]

Shouldn't these sanity checks be run on PyPy too? If they fail there is a problem with the PyPy build ...

[mayeut]

can't run the sanity check of the pipx.y symlink in /usr/local/bin since there are no symlink for PyPy pip in there. As mentioned in an earlier comment, going to remove those anyway.

For sqlite3, this is specific to cpython being rebuilt from source with a specific version (well should be specific, this has been an issue before). Given PyPY comes as a full featured binary, this check isn't right (& fails because the embedded sqlite3 is version 3.28 or 3.29 - I don't remember exactly)

[mattip]

the embedded sqlite3 is version 3.28 or 3.29

Hmm. Is it documented somewhere what sqlite3 a specific python version expects? If cpython is statically linking to 3.35 that would suggest PyPy should as well.

[mayeut]

The minimum sqlite3 version required by cpython is fairly low: https://github.com/python/cpython/blob/220dd80a2671f57486055955d5422163cf73ed33/Modules/_sqlite/module.c#L33

The default version in manylinux1 was even older than this requirement though:

• sqlite3 is broken under Python 3.6 #90
• Use a modern version of SQLite3 #93

It's been updated since then in order not to get issue reported because of CVE on older versions.

Windows/macOS installers of CPython also update sqlite3 regularly as noted in their release notes.

[mattip]

Thanks. I plan on releasing PyPy 7.3.5 in the next two days, so maybe merge only after that is released and can be used here?

[mayeut]

Thanks. I plan on releasing PyPy 7.3.5 in the next two days, so maybe merge only after that is released and can be used here?

Seems like a good plan.
Converted back to draft until updated to 7.3.5 to prevent this PR from being merged.
I'll also look into checking sha256 sums for downloaded packages.

[mattip]

PyPy 3.7.5 has been released. The checksums are available at https://www.pypy.org/checksums.html

[mattip]

Is there a way to test that this is working?

[mayeut]

Is there a way to test that this is working?

The tests in the manylinux repo are really minimal & PR images aren't uploaded anywhere.
All I can say is that it passes the same minimal tests as cpython here (mostly, we can install packages with pip and ssl connections are working properly).
I'll merge this once Travis CI is green to get some more tests running in pypa/cibuildwheel#671

[YannickJadoul]

Sorry for the delay, @mayeut. I don't know the manylinux images that well, but yeah, this PR seems to make sense to me :-)