-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update to PyPy 7.3.7 #1213
Conversation
Is there a way to get the autoconf download to retry a few times? It seems to fail to resolve fairly often. Or maybe cache it? |
Thanks, LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please check the failures?
manylinux2014_i686 failed due to a problem downloading autoconf, as mentioned above. This seems to be randomly happening about 5% of the time on runs. The musllinux_1_1_ppc64le failed on the openssl download, which I don't think it needed to download, as it already has 1.1.1l installed, and 1.1.1 is required. I don't understand why it's trying to download openssl, but I think it might be the same occasional failure to download as autoconf. We should be trying to download it 3 times, just in case that helps with the issue. |
Hmm, similar failure on #1214 - let's see what happens on the rebuild, and if that one job is still having issues, I'll look into it further. It's possible the cache is cold on that job, and the others would fail if the cache was cleared (depending on what's cached). It's also possible it's really an issue with just that one combination. |
Passed. |
7.3.7 is out with the needed critical fixes, will update this to that. |
Done. We should be able to add s390x, as well (doesn't have to be in this PR): https://downloads.python.org/pypy/ |
See #1210. This only reverts the 3.7.5 update for PyPy3.7, due to a binary incompatibility issue.