-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add URLs to linkcheck_ignore
#1881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
540f354 to
9cbbdbc
Compare
|
Any idea why the linkcheck fails? I don't see any log entries... |
This reverts commit fa92ece.
|
OK, I think I've fixed all errors... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Why does this have so many unrelated changes? Is it possible to make the diff small? |
|
It looks like @cbrnr went ahead and fixed some of the other URLs too (which were probably over-matching due to |
|
Exactly, the |
|
I tend to prefer atomic PRs. The title says it fixes one single URL but what I see in the diff is a bunch of other URLs with zero justification. Plus refactoring. Maybe something I missed in between these too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for simplifying the PR (and aligning the title with the content). LGTM, so I'm going to merge and unblock the other PRs affected by the link check failures.
The following URL caused the link checking to fail, so I added them to
linkcheck_ignore:r"https://math-atlas\.sourceforge\.net/?": 403 errorr"https://click\.palletsprojects\.com/.*": self-signed certificate errorr"https://typer\.tiangolo\.com/.*": self-signed certificate errorThis URL caused an anchor not found error:
r"https://docs\.github\.com/"📚 Documentation preview 📚: https://python-packaging-user-guide--1881.org.readthedocs.build/en/1881/