Skip to content

Conversation

@cbrnr
Copy link
Contributor

@cbrnr cbrnr commented Jul 22, 2025

The following URL caused the link checking to fail, so I added them to linkcheck_ignore:

  • r"https://math-atlas\.sourceforge\.net/?": 403 error
  • r"https://click\.palletsprojects\.com/.*": self-signed certificate error
  • r"https://typer\.tiangolo\.com/.*": self-signed certificate error

This URL caused an anchor not found error:

  • r"https://docs\.github\.com/"

📚 Documentation preview 📚: https://python-packaging-user-guide--1881.org.readthedocs.build/en/1881/

@cbrnr cbrnr mentioned this pull request Jul 22, 2025
@cbrnr cbrnr force-pushed the ignore-linkcheck-atlas branch from 540f354 to 9cbbdbc Compare July 22, 2025 11:43
@cbrnr
Copy link
Contributor Author

cbrnr commented Jul 22, 2025

Any idea why the linkcheck fails? I don't see any log entries...

@cbrnr
Copy link
Contributor Author

cbrnr commented Jul 22, 2025

OK, I think I've fixed all errors...

Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cbrnr, this LGTM (and would unblock other docs PRs).

CC @webknjaz @ncoghlan as editors 🙂

@webknjaz
Copy link
Member

Why does this have so many unrelated changes? Is it possible to make the diff small?

@woodruffw
Copy link
Member

It looks like @cbrnr went ahead and fixed some of the other URLs too (which were probably over-matching due to . being interpreted in regexes). I don't have a strong opinion on whether those changes should be included or not though.

@cbrnr
Copy link
Contributor Author

cbrnr commented Jul 30, 2025

Exactly, the linkcheck_ignore items are all regexes, and previously dots were not escaped (so matched any character). This is usually not really a problem in practice, but I thought while I'm at it I might as well fix all entries.

@webknjaz
Copy link
Member

I tend to prefer atomic PRs. The title says it fixes one single URL but what I see in the diff is a bunch of other URLs with zero justification. Plus refactoring. Maybe something I missed in between these too.

@cbrnr cbrnr changed the title Ignore linkcheck for ATLAS URL Add URLs to linkcheck_ignore Jul 31, 2025
Copy link
Member

@ncoghlan ncoghlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for simplifying the PR (and aligning the title with the content). LGTM, so I'm going to merge and unblock the other PRs affected by the link check failures.

@ncoghlan ncoghlan added this pull request to the merge queue Jul 31, 2025
Merged via the queue into pypa:main with commit 21e3032 Jul 31, 2025
7 checks passed
@cbrnr cbrnr deleted the ignore-linkcheck-atlas branch July 31, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants