Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHANGELOG.rst is not included in the source tarball, making the documentation unbuildable #688

Closed
doko42 opened this issue Apr 17, 2023 · 1 comment · Fixed by #704
Closed

CHANGELOG.rst is not included in the source tarball, making the documentation unbuildable #688

doko42 opened this issue Apr 17, 2023 · 1 comment · Fixed by #704
Labels
bug infrastructure

Comments

@doko42
Copy link

doko42 commented Apr 17, 2023

$ cat docs/changelog.rst
.. include:: ../CHANGELOG.rst

however it's not included in the source tarball
@brettcannon
Copy link
Member

Interested in opening a PR to update:

packaging/pyproject.toml

Line 38 in 55584fb

include = ["LICENSE*", "tests/", "docs/"]

?

astrojuanlu added a commit to astrojuanlu/packaging that referenced this issue Jul 25, 2023
@astrojuanlu
Include CHANGELOG.rst in sdist
cfde356 
Fix pypagh-688
@astrojuanlu astrojuanlu mentioned this issue Jul 25, 2023
Merged
brettcannon pushed a commit that referenced this issue Jul 26, 2023
@astrojuanlu
Include CHANGELOG.rst in sdist (#704)
3030822 
Fixes #688
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Include CHANGELOG.rst in sdist astrojuanlu/packaging
2 participants
@brettcannon @doko42