Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify some release details #392

Merged
merged 4 commits into from
Feb 6, 2021
Merged

Clarify some release details #392

merged 4 commits into from
Feb 6, 2021

Conversation

brettcannon
Copy link
Member

No description provided.

@brettcannon brettcannon requested a review from pradyunsg January 29, 2021 20:32
pradyunsg
pradyunsg reviewed Jan 31, 2021
View reviewed changes
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of opening the webbrowser, maybe we should make annotated tags instead?

@brettcannon
Copy link
Member Author

Either or. Do annotated tags lead to a GitHub release? It also won't lead to the wheel and sdist being attached to the GitHub release.

@pradyunsg
Copy link
Member

Hmm... Fair. It does lead to a release and I guess we can automate the rest later. :P

@brettcannon
Copy link
Member Author

#339 covers that and I would actually make it a GHA that uses a workflow_dispatch trigger so we can trigger from the browser, but otherwise does the entire release process (sans GPG signing) automatically.

@brettcannon
Copy link
Member Author

So do you still want to switch to an annotated tag, or is this good enough until we automate more?

pradyunsg
pradyunsg approved these changes Feb 3, 2021
View reviewed changes
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I thought I'd already green ticked this. Whoops!

@brettcannon
Copy link
Member Author

I will merge this once #376 is merged.

@brettcannon brettcannon merged commit cc5c2b2 into pypa:main Feb 6, 2021
@brettcannon brettcannon deleted the clarify-release-steps branch February 6, 2021 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pradyunsg pradyunsg pradyunsg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brettcannon @pradyunsg