Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ELF parsing logic to standlone class #553

Merged
merged 2 commits into from
Aug 26, 2022
Merged

Refactor ELF parsing logic to standlone class #553

merged 2 commits into from
Aug 26, 2022

Conversation

uranusjr
Copy link
Member

@uranusjr uranusjr commented Jun 3, 2022 •
edited by brettcannon
Loading

This makes it easier to reuse the same code for manylinux, musllinux, and test code.

@uranusjr uranusjr force-pushed the elfparser branch 7 times, most recently from 2388094 to 7e682e6 Compare June 3, 2022 02:46
@uranusjr uranusjr changed the title Correctly parse ELF for musllinux on Big Endian Refactor ELF parsing logic to standlone class Jun 3, 2022
@uranusjr uranusjr force-pushed the elfparser branch 4 times, most recently from d939262 to 3fc4c80 Compare June 3, 2022 03:19
@uranusjr uranusjr marked this pull request as ready for review July 19, 2022 05:39
brettcannon
brettcannon requested changes Aug 19, 2022
View reviewed changes
Copy link
Member

@brettcannon brettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically some expanded exception messages (which I realize shouldn't escape out to users, but we are people, too 😉), and some naming convention stuff.

packaging/_elffile.py Outdated Show resolved Hide resolved
packaging/_elffile.py Outdated Show resolved Hide resolved
packaging/_elffile.py Outdated Show resolved Hide resolved
packaging/_elffile.py Outdated Show resolved Hide resolved
packaging/_elffile.py Outdated Show resolved Hide resolved
packaging/_elffile.py Outdated Show resolved Hide resolved
packaging/_elffile.py Outdated Show resolved Hide resolved
packaging/_elffile.py Outdated Show resolved Hide resolved
tests/test_elffile.py Show resolved Hide resolved
@uranusjr
Refactor ELF parsing logic to standalone class
269e3f5 
This makes it easier to reuse the same code for manylinux, musllinux,
and test code.
@uranusjr
Better convention and exception message
ef7827d
@uranusjr uranusjr requested a review from brettcannon August 20, 2022 03:21
@brettcannon brettcannon merged commit 9385276 into pypa:main Aug 26, 2022
@brettcannon
Copy link
Member

Thanks!

KOLANICH pushed a commit to KOLANICH-libs/packaging that referenced this pull request Nov 30, 2022
@uranusjr @KOLANICH
Refactor ELF parsing logic to standalone class (pypa#553)
6dc74db
@j01101111sh j01101111sh mentioned this pull request Dec 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettcannon brettcannon brettcannon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uranusjr @brettcannon