Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document markers.default_environment() #753

Merged
merged 12 commits into from
Mar 11, 2024
Merged

Document markers.default_environment() #753

merged 12 commits into from
Mar 11, 2024

Conversation

edgarrmondragon
Copy link
Contributor

@edgarrmondragon edgarrmondragon commented Dec 21, 2023 •
edited
Loading

@edgarrmondragon edgarrmondragon force-pushed the document-default-environment branch from 854c880 to ecc9aec Compare December 21, 2023 06:16
@edgarrmondragon edgarrmondragon marked this pull request as ready for review December 21, 2023 20:55
@edgarrmondragon edgarrmondragon marked this pull request as draft December 21, 2023 22:33
@edgarrmondragon edgarrmondragon force-pushed the document-default-environment branch 5 times, most recently from c4384cc to 701cc51 Compare December 21, 2023 23:38
@edgarrmondragon edgarrmondragon force-pushed the document-default-environment branch from 701cc51 to e46128e Compare December 21, 2023 23:45
@edgarrmondragon edgarrmondragon marked this pull request as ready for review December 21, 2023 23:46
@brettcannon brettcannon mentioned this pull request Dec 22, 2023
Closed
@brettcannon brettcannon self-requested a review January 4, 2024 21:04
brettcannon
brettcannon requested changes Jan 4, 2024
View reviewed changes
src/packaging/markers.py Outdated Show resolved Hide resolved
pradyunsg
pradyunsg reviewed Jan 20, 2024
View reviewed changes
src/packaging/markers.py Outdated Show resolved Hide resolved
@edgarrmondragon
Copy link
Contributor Author

I believe I've addressed all the feedback, so let me know if you'd like to see other changes

brettcannon
brettcannon requested changes Jan 26, 2024
View reviewed changes
Copy link
Member

@brettcannon brettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc tweak to align w/ what the TypedDict is being used for.

docs/markers.rst Outdated Show resolved Hide resolved
@edgarrmondragon @brettcannon
Update docs/markers.rst
89c0917 
Co-authored-by: Brett Cannon <brett@python.org>
@brettcannon
Copy link
Member

@pradyunsg you good w/ this approach of a TypedDict for the specific return type?

pradyunsg
pradyunsg reviewed Mar 10, 2024
View reviewed changes
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although this will need a rebase due to #783 dropping 3.7 support (which requires changes to _typing.py introduced here).

@edgarrmondragon edgarrmondragon force-pushed the document-default-environment branch from 2ebebc1 to 15d5e8a Compare March 11, 2024 00:35
@edgarrmondragon
Copy link
Contributor Author

I took the liberty of bumping the required Python version in RTD to 3.9, since that's also the version specified for the docs Nox session.

@brettcannon brettcannon merged commit e0dda88 into pypa:main Mar 11, 2024
33 checks passed
@brettcannon
Copy link
Member

Thanks, @edgarrmondragon !

@edgarrmondragon edgarrmondragon deleted the document-default-environment branch March 12, 2024 02:42
@vasudev-gm vasudev-gm mentioned this pull request Jun 10, 2024
Closed
kodiakhq bot referenced this pull request in cloudquery/plugin-sdk-python Jul 1, 2024
@cq-bot
fix(deps): Update dependency packaging to v24.1 (#194)
73d18ca 
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [packaging](https://togithub.com/pypa/packaging) | minor | `==24.0` -> `==24.1` |

---

### Release Notes

<details>
<summary>pypa/packaging (packaging)</summary>

### [`v24.1`](https://togithub.com/pypa/packaging/releases/tag/24.1)

[Compare Source](https://togithub.com/pypa/packaging/compare/24.0...24.1)

#### What's Changed

-   pyupgrade/black/isort/flake8 → ruff by [@&#8203;DimitriPapadopoulos](https://togithub.com/DimitriPapadopoulos) in [https://github.com/pypa/packaging/pull/769](https://togithub.com/pypa/packaging/pull/769)
-   Add support for Python 3.13 and drop EOL 3.7 by [@&#8203;hugovk](https://togithub.com/hugovk) in [https://github.com/pypa/packaging/pull/783](https://togithub.com/pypa/packaging/pull/783)
-   Bump the github-actions group with 4 updates by [@&#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/pypa/packaging/pull/782](https://togithub.com/pypa/packaging/pull/782)
-   Fix typo in `_parser` docstring by [@&#8203;pradyunsg](https://togithub.com/pradyunsg) in [https://github.com/pypa/packaging/pull/784](https://togithub.com/pypa/packaging/pull/784)
-   Modernise type annotations using FA rules from ruff by [@&#8203;pradyunsg](https://togithub.com/pradyunsg) in [https://github.com/pypa/packaging/pull/785](https://togithub.com/pypa/packaging/pull/785)
-   Document `markers.default_environment()` by [@&#8203;edgarrmondragon](https://togithub.com/edgarrmondragon) in [https://github.com/pypa/packaging/pull/753](https://togithub.com/pypa/packaging/pull/753)
-   Bump the github-actions group with 3 updates by [@&#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/pypa/packaging/pull/789](https://togithub.com/pypa/packaging/pull/789)
-   Work around platform.python_version() returning non PEP 440 compliant version for non-tagged CPython builds by [@&#8203;sbidoul](https://togithub.com/sbidoul) in [https://github.com/pypa/packaging/pull/802](https://togithub.com/pypa/packaging/pull/802)

#### New Contributors

-   [@&#8203;dependabot](https://togithub.com/dependabot) made their first contribution in [https://github.com/pypa/packaging/pull/782](https://togithub.com/pypa/packaging/pull/782)
-   [@&#8203;edgarrmondragon](https://togithub.com/edgarrmondragon) made their first contribution in [https://github.com/pypa/packaging/pull/753](https://togithub.com/pypa/packaging/pull/753)

**Full Changelog**: pypa/packaging@24.0...24.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on the first day of the month" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjEuMyIsInVwZGF0ZWRJblZlciI6IjM3LjQyMS4zIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJhdXRvbWVyZ2UiXX0=-->
@renovate renovate bot mentioned this pull request Jul 12, 2024
Open
1 task
@renovate renovate bot mentioned this pull request Jul 21, 2024
Merged
1 task
@never147 never147 mentioned this pull request Nov 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pradyunsg pradyunsg pradyunsg approved these changes

@brettcannon brettcannon brettcannon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@edgarrmondragon @brettcannon @pradyunsg