Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix prerelease detection for > and < #794

Merged
merged 5 commits into from
Sep 16, 2024
Merged

Fix prerelease detection for > and < #794

merged 5 commits into from
Sep 16, 2024

Conversation

notatallshaw
Copy link
Member

@notatallshaw notatallshaw commented Apr 13, 2024 •
edited
Loading

Fixes #788

And adds an explicit test for != based on #776 (comment)

This was referenced Apr 13, 2024
Open
Closed
Open
@notatallshaw
Copy link
Member Author

Feedback would be appreciated.

@uranusjr
Copy link
Member

And adds an explicit test for !=

Is this for another PR? I don’t see the change here.

@notatallshaw
Copy link
Member Author

notatallshaw commented May 20, 2024 •
edited
Loading

And adds an explicit test for !=

Is this for another PR? I don’t see the change here.

It's in this PR, it's in the change to tests/test_specifiers.py

@notatallshaw
Copy link
Member Author

I tried to merge branch with 'main' to make sure this PR was still good, but forgot I don't have automatic CI rights, if someone could approve CI run I'd be appreciative.

@notatallshaw
Copy link
Member Author

Anything blocking this? Do I need to do anything for a changelog entry here?

@pradyunsg pradyunsg force-pushed the fix-prerelease-detection-for->-and-< branch from d70d341 to a0e7b90 Compare August 4, 2024 22:21
brettcannon
brettcannon requested changes Aug 8, 2024
View reviewed changes
Copy link
Member

@brettcannon brettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#788 (comment) has some examples. We probably should have some tests for those.

@notatallshaw notatallshaw force-pushed the fix-prerelease-detection-for->-and-< branch from 0a4eec2 to 42c1f6d Compare August 16, 2024 22:52
@notatallshaw
Copy link
Member Author

#788 (comment) has some examples. We probably should have some tests for those.

Added specifier tests to match.

@notatallshaw notatallshaw mentioned this pull request Aug 26, 2024
Open
@notatallshaw notatallshaw force-pushed the fix-prerelease-detection-for->-and-< branch 3 times, most recently from 0f814e5 to cf7ad44 Compare August 26, 2024 23:21
@notatallshaw notatallshaw force-pushed the fix-prerelease-detection-for->-and-< branch from cf7ad44 to 843c31c Compare August 26, 2024 23:40
@notatallshaw
Copy link
Member Author

notatallshaw commented Aug 26, 2024 •
edited
Loading

The specifics of this came up today in astral-sh/uv#6640

It reminded me to check this PR, it seems there was a transient CI error, I added some more tests (and after correcting them) the transient CI error vanished.

@notatallshaw notatallshaw mentioned this pull request Sep 8, 2024
Open
@brettcannon brettcannon mentioned this pull request Sep 16, 2024
Closed
@brettcannon
Copy link
Member

I'm going to give @pradyunsg a chance to (dis)agree to the semantic change before I merge.

@brettcannon brettcannon merged commit cf2cbe2 into pypa:main Sep 16, 2024
32 checks passed
@brettcannon
Copy link
Member

Thanks, @notatallshaw !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettcannon brettcannon brettcannon approved these changes

@uranusjr uranusjr uranusjr approved these changes

@pradyunsg pradyunsg pradyunsg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Specifier < that contains prerelease version does not match on valid prerelease versions
4 participants
@notatallshaw @uranusjr @brettcannon @pradyunsg