chore: update pre-commit pins and fix issues #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
commented
Sep 27, 2024
src/packaging/metadata.py
Outdated
| if "ExceptionGroup" in builtins.__dict__: # pragma: no cover | ||
| ExceptionGroup = ExceptionGroup | ||
| else: # pragma: no cover | ||
| if "ExceptionGroup" not in builtins.__dict__: # pragma: no cover |
There was a problem hiding this comment.
I flipped the order here to get the custom type to stick.
IMO, this should be if sys.version_info < (3, 11) instead.
There was a problem hiding this comment.
Actually, getting the type check right is tricky without it, so switching it to the version check now.
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
commented
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps things like Ruff and MyPy and applied the simplest (minimal change) fixes for the issues. Longer term, asserts could remove some of the type ignores.