Check should_ignore in if condiition

pypa · Jun 27, 2020 · 1da909e · 1da909e
1 parent ecbe065
commit 1da909e
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/src/pip/_internal/operations/check.py b/src/pip/_internal/operations/check.py
@@ -61,10 +61,8 @@ def check_package_set(package_set, should_ignore=None):
     If should_ignore is passed, it should be a callable that takes a
     package name and returns a boolean.
     """
-    if should_ignore:
-        should_ignore_package = should_ignore
-    else:
-        def should_ignore_package(name):
+    if should_ignore is None:
+        def should_ignore(name):
             # type: (str) -> bool
             return False
 
@@ -76,7 +74,7 @@ def should_ignore_package(name):
         missing_deps = set()  # type: Set[Missing]
         conflicting_deps = set()  # type: Set[Conflicting]
 
-        if should_ignore_package(package_name):
+        if should_ignore and should_ignore(package_name):
             continue
 
         for req in package_set[package_name].requires: