Skip to content

Commit

Permalink
Not clear why this didn't fail before...
Browse files Browse the repository at this point in the history
  • Loading branch information
pfmoore committed Oct 27, 2020
1 parent 0c2a2bc commit 3408604
Showing 1 changed file with 0 additions and 32 deletions.
32 changes: 0 additions & 32 deletions tests/functional/test_install_cleanup.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,38 +26,6 @@ def test_no_clean_option_blocks_cleaning_after_install(script, data):
assert exists(build)


@pytest.mark.network
def test_cleanup_prevented_upon_build_dir_exception(
script,
data,
use_new_resolver,
):
"""
Test no cleanup occurs after a PreviousBuildDirError
"""
build = script.venv_path / 'build'
build_simple = build / 'simple'
os.makedirs(build_simple)
build_simple.joinpath("setup.py").write_text("#")
result = script.pip(
'install', '-f', data.find_links, '--no-index', 'simple',
'--build', build,
expect_error=(not use_new_resolver),
expect_temp=(not use_new_resolver),
expect_stderr=True,
)

assert (
"The -b/--build/--build-dir/--build-directory "
"option is deprecated."
) in result.stderr

if not use_new_resolver:
assert result.returncode == PREVIOUS_BUILD_DIR_ERROR, str(result)
assert "pip can't proceed" in result.stderr, str(result)
assert exists(build_simple), str(result)


@pytest.mark.network
def test_pep517_no_legacy_cleanup(script, data, with_wheel):
"""Test a PEP 517 failed build does not attempt a legacy cleanup"""
Expand Down

0 comments on commit 3408604

Please sign in to comment.