do not repeat tests in should_cache

pypa · Oct 27, 2019 · 34148bf · 34148bf
1 parent 1283a30
commit 34148bf
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/src/pip/_internal/wheel.py b/src/pip/_internal/wheel.py
@@ -815,10 +815,11 @@ def should_cache(
     wheel cache, assuming the wheel cache is available, and should_build()
     has determined a wheel needs to be built.
     """
-    if req.editable or not req.source_dir:
-        return False
-
-    if not check_binary_allowed(req):
+    if not should_build(
+        req, need_wheel=False, check_binary_allowed=check_binary_allowed
+    ):
+        # never cache if pip install (need_wheel=False) would not have built
+        # (editable mode, etc)
         return False
 
     if req.link and req.link.is_vcs: