Assert spinner instead of if condition check

pypa · Jun 26, 2020 · 4d55a57 · 4d55a57
1 parent 36af6f6
commit 4d55a57
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/pip/_internal/utils/subprocess.py b/src/pip/_internal/utils/subprocess.py
@@ -206,7 +206,8 @@ def call_subprocess(
         # Show the line immediately.
         log_subprocess(line)
         # Update the spinner.
-        if use_spinner and spinner:
+        assert spinner
+        if use_spinner:
             spinner.spin()
     try:
         proc.wait()
@@ -216,7 +217,8 @@ def call_subprocess(
     proc_had_error = (
         proc.returncode and proc.returncode not in extra_ok_returncodes
     )
-    if use_spinner and spinner:
+    assert spinner
+    if use_spinner:
         if proc_had_error:
             spinner.finish("error")
         else: