Raise error if --user and --target arguments are used together

pypa · Feb 24, 2020 · 4ed5019 · 4ed5019
1 parent ea47be5
commit 4ed5019
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 5 deletions.
diff --git a/news/7249.feature b/news/7249.feature
@@ -0,0 +1 @@
+Raise error if --user and --target are used together in command
diff --git a/src/pip/_internal/cli/main_parser.py b/src/pip/_internal/cli/main_parser.py
@@ -83,6 +83,17 @@ def parse_command(args):
  # the subcommand name
  cmd_name = args_else[0]
 
+ validate_command_args(cmd_name, args_else)
+
+ # all the args without the subcommand
+ cmd_args = args[:]
+ cmd_args.remove(cmd_name)
+
+ return cmd_name, cmd_args
+
+
+def validate_command_args(cmd_name, args_else):
+ # type: (str, List[str]) -> None
  if cmd_name not in commands_dict:
  guess = get_similar_commands(cmd_name)
 
@@ -92,8 +103,6 @@ def parse_command(args):
 
  raise CommandError(' - '.join(msg))
 
- # all the args without the subcommand
- cmd_args = args[:]
- cmd_args.remove(cmd_name)
-
- return cmd_name, cmd_args
+ if set(['--user', '--target']).issubset(set(args_else)):
+ error_msg = '--user and --target cant not be used together.'
+ raise CommandError(error_msg)