Merge pull request #10697 from jiunbae/main

Resolves junction links when deleting packages installed as editable
pypa · Feb 19, 2022 · d35bedc · d35bedc
2 parents 0c6d20f + 84c8a4c
commit d35bedc
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/news/10696.bugfix.rst b/news/10696.bugfix.rst
@@ -0,0 +1 @@
+Fix uninstall editable from Windows junction link.
diff --git a/src/pip/_internal/req/req_uninstall.py b/src/pip/_internal/req/req_uninstall.py
@@ -527,7 +527,7 @@ def from_dist(cls, dist: BaseDistribution) -> "UninstallPathSet":
             # above, so this only covers the setuptools-style editable.
             with open(develop_egg_link) as fh:
                 link_pointer = os.path.normcase(fh.readline().strip())
-            assert link_pointer == dist_location, (
+            assert os.path.samefile(link_pointer, dist_location), (
                 f"Egg-link {link_pointer} does not match installed location of "
                 f"{dist.raw_name} (at {dist_location})"
             )