Merge pull request #9171 from webknjaz/bugfixes/docs-feedback-sphinxe…

…xt-orphan
pypa · Nov 29, 2020 · d91b7d9 · d91b7d9
2 parents b6ca743 + 8cfdb45
commit d91b7d9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/docs/docs_feedback_sphinxext.py b/docs/docs_feedback_sphinxext.py
@@ -111,7 +111,7 @@ def _modify_rst_document_source_on_read(
     orphan_mark = ':orphan:'
     is_orphan = orphan_mark in source[0]
     if is_orphan:
-        source[0].replace(orphan_mark, '')
+        source[0] = source[0].replace(orphan_mark, '')
     else:
         orphan_mark = ''
 

diff --git a/news/9171.trivial.rst b/news/9171.trivial.rst
@@ -0,0 +1,3 @@
+Fixed moving the ``:orphan:`` to top of documents in the Sphinx
+extension for collecting the UX feedback from docs (initially
+introduced in PR #8848).