Skip to content

Commit

Permalink
Fix a few typing issues
Browse files Browse the repository at this point in the history
  • Loading branch information
sbidoul committed Dec 17, 2023
1 parent b23341d commit fb1be0f
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
6 changes: 3 additions & 3 deletions tests/functional/test_new_resolver.py
Original file line number Diff line number Diff line change
Expand Up @@ -2295,7 +2295,7 @@ def test_new_resolver_dont_backtrack_on_extra_if_base_constrained_in_requirement
script, "pkg", "2.0", extras={"ext1": ["dep"], "ext2": ["dep"]}
)

to_install: tuple[str, str] = (
to_install: Tuple[str, str] = (
"pkg[ext1]",
"pkg[ext2]==1.0" if two_extras else "pkg==1.0",
)
Expand Down Expand Up @@ -2342,7 +2342,7 @@ def test_new_resolver_dont_backtrack_on_conflicting_constraints_on_extras(
script, "pkg", "2.0", extras={"ext1": ["dep"], "ext2": ["dep"]}
)

to_install: tuple[str, str] = (
to_install: Tuple[str, str] = (
"pkg[ext1]>1",
"pkg[ext2]==1.0" if two_extras else "pkg==1.0",
)
Expand Down Expand Up @@ -2506,7 +2506,7 @@ def test_new_resolver_comes_from_with_extra(
create_basic_wheel_for_package(script, "dep", "1.0")
create_basic_wheel_for_package(script, "pkg", "1.0", extras={"ext": ["dep"]})

to_install: tuple[str, str] = ("pkg", "pkg[ext]")
to_install: Tuple[str, str] = ("pkg", "pkg[ext]")

result = script.pip(
"install",
Expand Down
5 changes: 3 additions & 2 deletions tools/update-rtd-redirects.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import os
import sys
from pathlib import Path
from typing import Dict, List

import httpx
import rich
Expand Down Expand Up @@ -84,8 +85,8 @@ def get_rtd_api() -> httpx.Client:

next_step("Compare and determine modifications.")

redirects_to_remove: list[int] = []
redirects_to_add: dict[str, str] = {}
redirects_to_remove: List[int] = []
redirects_to_add: Dict[str, str] = {}

for redirect in rtd_redirects["results"]:
if redirect["type"] != "exact":
Expand Down

0 comments on commit fb1be0f

Please sign in to comment.