Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

October 2021 Release #10488

Closed
uranusjr opened this issue Sep 20, 2021 · 23 comments
Closed

October 2021 Release #10488

uranusjr opened this issue Sep 20, 2021 · 23 comments
Assignees
Labels
type: maintenance Related to Development and Maintenance Processes

Comments

@uranusjr
Copy link
Member

uranusjr commented Sep 20, 2021

Tracking issue for pip 21.3.

Anyone volunteers to be the release manager @pypa/pip-committers?

@uranusjr uranusjr added type: feature request Request for a new feature S: needs triage Issues/PRs that need to be triaged labels Sep 20, 2021
@uranusjr uranusjr added this to the 21.3 milestone Sep 20, 2021
@uranusjr uranusjr added type: maintenance Related to Development and Maintenance Processes and removed type: feature request Request for a new feature S: needs triage Issues/PRs that need to be triaged labels Sep 20, 2021
@sbidoul
Copy link
Member

sbidoul commented Sep 21, 2021

I can not be the release manager for this one: October being the month of the annual Odoo release I'll be too busy in the Odoo community. I may take January or April.

I'll be around to help, and at least handle any issues related to editables, though.

@pfmoore
Copy link
Member

pfmoore commented Sep 21, 2021

I might be able to make time for this, but only if it's a relatively routine release. I definitely won't be able to support multiple followup bugfix releases, so if we aren't OK with taking a hard line with "it'll be sorted in 22.1 and not before", then I'd rather not take this on. IMO, we've got into a habit of releasing too many bugfix releases, and it's not practical to sustain given the level of resource we have.

Are we comfortable with a release on a weekend early in Oct, shipped from whatever is on main at that point, with no commitment to bugfix releases for anything beyond complete showstoppers?

@pradyunsg
Copy link
Member

I'm happy to pick up the baton for this time around, given that everyone else has limited availability. :)

I expect there to be a bunch of activity and fallout in this release, since we're going to ship in-tree-build-by-default, will likely try to ship editables support, and have a bunch of removals (there's a few gone_in="21.3" deprecations) as well.

@pfmoore
Copy link
Member

pfmoore commented Sep 21, 2021

OK, cool. I still think we should as a matter of principle try to cut back on the number of bugfix releases we do. Either that, or we may start to find that a 3-month release cycle isn't sustainable (we've barely finished doing 21.2 bugfix releases and we're starting on 21.3).

Maybe we need to have a separate issue to review our release policy?

@pradyunsg pradyunsg self-assigned this Sep 21, 2021
@pradyunsg
Copy link
Member

pradyunsg commented Sep 21, 2021

Maybe we need to have a separate issue to review our release policy?

I'm ambivalent. This works, so does a separate issue. :)

I still think we should as a matter of principle try to cut back on the number of bugfix releases we do. Either that, or we may start to find that a 3-month release cycle isn't sustainable

I tend to agree.

FWIW, I'm also fine with deferring that decision to whomever is cutting the releases. I personally prefer to keeping the issue open as short as possible, actually getting the first release on a week day in the first half of the month and so on -- all of which was tricky with the resolver rollout. And I was full-time working on pip in that period. :)

Anyway, for 21.2, we had a whole bunch of follow ups on the sysconfig <-> distutils migration and the resolver -- but the issue stayed open for quite a while after the final release "just in case", which... meh, it's fine but we can also get away with not doing that.

@uranusjr
Copy link
Member Author

I think the sysconfig thing needs to stay open for a while since there are still some obscure issues popping up once in a while. Or alternatively, since we’ve already committed to the switch in 3.10 and those cases are obscure anyway, we can completely silence the warning in 21.3 and see what happens after 3.10.

@pradyunsg
Copy link
Member

but the issue stayed open for quite a while after the final release "just in case"

I was referring to the release issue, not the sysconfig migration-related reporting location. :)

And, definitely agree that we should keep the warnings around for a while. Ambivalent on what to do for 3.10+ -- I'm inclined to keep them as-is, until we drop distutils entirely from 3.12. 🤷🏽

@pradyunsg pradyunsg pinned this issue Oct 3, 2021
@pradyunsg
Copy link
Member

Alrighty, two release blockers left:

  • A decently important resolver improvement.
  • Dropping a deprecated items
    • --build-dir
    • sdist reinstall behaviour

Looks like they're all tasks I ended up picking up, so if someone wants to help out with the reviews of my PRs or the resolvelib side of things, that'd be nice. 😅

@pradyunsg
Copy link
Member

pradyunsg commented Oct 9, 2021

Alrighty. Blocked on one last improvement: #10481.

And assuming that'll land, I'll cut a release today (if it happens soon enough) / tomorrow / early next week.

@pradyunsg
Copy link
Member

And... all blockers are resolved.

I intend to cut the release 6:30pm UK time on Monday, Oct 11.

@pradyunsg
Copy link
Member

21.3 is released!

@uranusjr
Copy link
Member Author

How about CPython, or should we wait a while to make sure there are no urgent bugs?

@pradyunsg
Copy link
Member

Well, if we had urgent bugs, we would've seen an issue about it already. :P

None the less, I'll do the CPython PR after work tomorrow.

@pradyunsg pradyunsg modified the milestones: 21.3, 21.3.1 Oct 14, 2021
@pradyunsg
Copy link
Member

One bugfix to go!

None the less, I'll do the CPython PR after work tomorrow.

Haven't done this, since we broke editable installs. 😅

@pradyunsg
Copy link
Member

Ahoy folks -- consider main open for development. I'll cherry pick the merged PRs in the 21.3.1 milestone, for making the release.

@pradyunsg
Copy link
Member

Alright. Will cut 21.3.1 today.

Thanks @sbidoul and @uranusjr for picking up the editable installs issue and driving it to completion. ^.^

@johnandersen777

This comment has been minimized.

@sbidoul

This comment has been minimized.

@johnandersen777

This comment has been minimized.

@sbidoul

This comment has been minimized.

@johnandersen777

This comment has been minimized.

This was referenced Oct 22, 2021
@pradyunsg
Copy link
Member

And... it's online.

I'll file a PR against CPython in a few minutes.


Unless there's a show stopper issue over the weekend, I expect this to be the final pip release for this year. :)

@pradyunsg
Copy link
Member

And, that's a wrap for 21.3.

See y'all next year; unless I get an email from security@python.org. :)

@pradyunsg pradyunsg unpinned this issue Nov 3, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: maintenance Related to Development and Maintenance Processes
Projects
None yet
Development

No branches or pull requests

5 participants