-
-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for pip>=21.3
#1501
Conversation
@AndydeCleyre I've prepared |
@jazzband/pip-tools now this is all set up and ready for review. |
Thanks @ssbarnea 🙏🏻 |
Nopb. I was bit confused by the fact the pip version bumping was merged before that change but no problem. I hope to see this released ASAP as I do not want to have to update deps to avoid errors (or pin down pip). |
@@ -3,6 +3,7 @@ | |||
import json | |||
import os | |||
import shlex | |||
import typing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know I'm late, but importing typing
directly (and later using typing.Union
rather than just Union
) seems unnecessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 👍🏻
thanks for the super quick fix, everyone! Saw this breaking across my cicd's and I was beginning to pin pip version... |
Changes:
pip._internal.utils.misc.get_installed_distributions
used inpiptools.scripts.sync
TODO:
>= 21.2
#1500Contributor checklist
Maintainer checklist
backwards incompatible
,feature
,enhancement
,deprecation
,bug
,dependency
,docs
orskip-changelog
as they determine changelog listing.Fixes #1503