uninstall check should use samefile(), not ==

[jhermann]

Environment

• pip version: 10.0.1
• Python version: 2.7
• OS: Ubuntu

Description

The assertion at

pip/src/pip/_internal/req/req_uninstall.py

Line 362 in 729990c

assert (link_pointer == dist.location), (

should use os.path.samefile to compare paths. Hot-patching this in lib of a virtualenv solved my problem.

If you agree, I can prepare a PR.

Expected behavior

Uninstall should succeed in the face of symlinked project paths.

How to Reproduce

Not sure exactly, but have symlinks in the path to your virtualenv / project, so there are two alternative root paths.

[HaraldNordgren]

Hi, I created a PR:

• Handle symlinks in req_uninstall.py #5442

The samefile solution seems to fail on Windows, but I found another solution here (general03/flask-autoindex#14) to use os.stat instead.

[uranusjr]

Fixed in #10697.