Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protect_pip_from_modification_on_windows check breaks some valid use cases #7358

Closed
benoit-pierre opened this issue Nov 15, 2019 · 1 comment · Fixed by #7557
Closed

protect_pip_from_modification_on_windows check breaks some valid use cases #7358

benoit-pierre opened this issue Nov 15, 2019 · 1 comment · Fixed by #7557
Labels
auto-locked Outdated issues that have been locked by automation OS: windows Windows specific !release blocker Hold a release until this is resolved type: bug A confirmed bug or unintended behavior
Milestone
20.0

Comments

@benoit-pierre
Copy link
Member

Environment

  • pip version: 19.3.1
  • Python version: 3.6.8
  • OS: Windows

Description

The protect_pip_from_modification_on_windows check can error out on some valid use cases (with no attempt to modify the calling pip's executable that would run foul of Windows limitations). E.g.:

  • python src/pip install pip
  • pip install -t target pip
  • ...

The call when installing build requirements is probably impacted too.

Setuptools test suite is hit by this issue: see this code. Note that the issue does not seem to occur with Python 2.7.17: https://ci.appveyor.com/project/jaraco/setuptools/builds/28883044.
@triage-new-issues triage-new-issues bot added the S: needs triage Issues/PRs that need to be triaged label Nov 15, 2019
benoit-pierre referenced this issue Nov 15, 2019
@atugushev
Address review comments
a1fa84e 
Handle the case of invoking pip via pip3 and pip3.7
@benoit-pierre benoit-pierre changed the title protect_pip_from_modification_on_windows check breaks some valid use cases the protect_pip_from_modification_on_windows check breaks some valid use cases Nov 15, 2019
@benoit-pierre benoit-pierre changed the title the protect_pip_from_modification_on_windows check breaks some valid use cases protect_pip_from_modification_on_windows check breaks some valid use cases Nov 15, 2019
@pradyunsg pradyunsg added OS: windows Windows specific type: bug A confirmed bug or unintended behavior and removed S: needs triage Issues/PRs that need to be triaged labels Nov 15, 2019
@pradyunsg pradyunsg added the !release blocker Hold a release until this is resolved label Jan 6, 2020
@pradyunsg pradyunsg added this to the 20.0 milestone Jan 6, 2020
@pradyunsg
Copy link
Member

pradyunsg commented Jan 6, 2020 •
edited
Loading

We should revert #6864 until we can figure this out. This is a pretty major bug that affects anyone doing pip-related development on Windows (like @uranusjr).

This was referenced Jan 6, 2020
Merged
Merged
@uranusjr uranusjr mentioned this issue Jan 6, 2020
Closed
@uranusjr uranusjr mentioned this issue Jan 7, 2020
Closed
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Feb 6, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation OS: windows Windows specific !release blocker Hold a release until this is resolved type: bug A confirmed bug or unintended behavior
Projects
None yet
Milestone
20.0
Development

Successfully merging a pull request may close this issue.

Revert addition of un-suffixed pip CLI entry points for invocation check on Windows pradyunsg/pip
2 participants
@pradyunsg @benoit-pierre